Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Vite @vitejs/plugin-react also in production #18759

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

platosha
Copy link
Contributor

@platosha platosha commented Feb 20, 2024

Vite's esbuild JSX output in production has some incompatibility with the Preact Signals library. As a workaround, this change applies JSX transformation provided by @vitejs/plugin-react in production mode.

Required by: vaadin/hilla#2043

Vite's esbuild JSX output in production has some incompatibility with the
Preact Signals library. As a workaround, this change applies JSX
transformation provided by `@vitejs/plugin-react` in production mode.

Required by: vaadin/hilla#2043
Copy link

Test Results

19 files   -  3  19 suites   - 3   7m 4s ⏱️ - 1m 6s
81 tests +40  79 ✅ +40  2 💤 ±0  0 ❌ ±0 
81 runs  +36  79 ✅ +36  2 💤 ±0  0 ❌ ±0 

Results for commit 0c1e650. ± Comparison against base commit 8fe7c27.

This pull request removes 38 and adds 78 tests. Note that renamed tests count towards both.
com.vaadin.flow.custom.CustomRouteIT ‑ CustomRegistry_hasExpectedErrorHandlers[any_Chrome_]
com.vaadin.flow.custom.CustomRouteIT ‑ testCustomErrorView[any_Chrome_]
com.vaadin.flow.devbuild.DevBundleThemeIT ‑ noVaadinSegmentInTheURL_notFound[any_Chrome_]
com.vaadin.flow.devbuild.DevBundleThemeIT ‑ serveStylesInExpressBuildMode_assetsAreCopiedToBundle[any_Chrome_]
com.vaadin.flow.devbuild.DevBundleThemeIT ‑ serveStylesInExpressBuildMode_changeStyles_stylesUpdatedWithoutBundleRecompilation[any_Chrome_]
com.vaadin.flow.devbuild.DevBundleThemeIT ‑ themeAndParentThemeLoaded[any_Chrome_]
com.vaadin.flow.devbuild.DevBundleThemeIT ‑ themeComponentsCssAddedToStats[any_Chrome_]
com.vaadin.flow.devbuild.DevBundleThemeIT ‑ themeJsonContentAddedToStats[any_Chrome_]
com.vaadin.flow.devbuild.ParentThemeIT ‑ parentTheme_stylesAppliedFromParentTheme[any_Chrome_]
com.vaadin.flow.devbuild.ParentThemeInFrontendIT ‑ parentThemeInFrontendFolder_stylesAppliedFromParentTheme[any_Chrome_]
…
com.vaadin.flow.ReactAdapterIT ‑ validateGetState[any_Chrome_]
com.vaadin.flow.ReactAdapterIT ‑ validateInitialState[any_Chrome_]
com.vaadin.flow.ReactAdapterIT ‑ validateListener[any_Chrome_]
com.vaadin.flow.ReactAdapterIT ‑ validateSetState[any_Chrome_]
com.vaadin.flow.ccdmtest.AppThemeTestIT ‑ should_apply_AppTheme_on_clientSideView[any_Chrome_]
com.vaadin.flow.ccdmtest.AppThemeTestIT ‑ should_apply_AppTheme_on_serverSideView[any_Chrome_]
com.vaadin.flow.ccdmtest.CCDMTest ‑ Unknown test
com.vaadin.flow.ccdmtest.IndexHtmlRequestHandlerIT ‑ indexHtmlRequestHandler_importDynamically_shouldLoadBundleCorrectly[any_Chrome_]
com.vaadin.flow.ccdmtest.IndexHtmlRequestHandlerIT ‑ indexHtmlRequestHandler_openRandomRoute_shouldResponseIndexHtml[any_Chrome_]
com.vaadin.flow.ccdmtest.IndexHtmlRequestHandlerIT ‑ indexHtmlRequestHandler_openRootURL_shouldAddBaseHref[any_Chrome_]
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
com.vaadin.flow.testnpmonlyfeatures.performanceregression.StartupPerformanceIT ‑ devModeInitializerToWebpackUpIsBelowThreshold[any_Chrome_]
com.vaadin.flow.ccdmtest.CCDMTest ‑ Unknown test

Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@platosha platosha merged commit 83c552a into main Feb 21, 2024
26 of 30 checks passed
@platosha platosha deleted the fix/ap/vite-react-plugin-production branch February 21, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants