-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: resolve circular dependency #570
Conversation
Codecov ReportBase: 96.67% // Head: 96.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
=======================================
Coverage 96.67% 96.67%
=======================================
Files 28 28
Lines 4659 4659
Branches 300 300
=======================================
Hits 4504 4504
Misses 152 152
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
13f9f67
to
fb91ddb
Compare
the error from the validation is
and there is a missing dependency in vaadin-checkbox-group, let us try this after the next web-component release. |
Kudos, SonarCloud Quality Gate passed!
|
* chore: resolve circular dependency * chore: add lumo dependency * chore: component view dependency * chore: move component dependency to test root * chore:add custom-field dependency
* chore: resolve circular dependency (#570) * chore: resolve circular dependency * chore: add lumo dependency * chore: component view dependency * chore: move component dependency to test root * chore:add custom-field dependency * chore: Make project work with latest Flow (#627) * chore: update TB to latest Co-authored-by: Artur <artur@vaadin.com>
with this PR, we aim to remove the circular dependency issue in hilla from vaadin-platform.