Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve circular dependency #570

Merged
merged 7 commits into from
Oct 28, 2022
Merged

chore: resolve circular dependency #570

merged 7 commits into from
Oct 28, 2022

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Sep 28, 2022

with this PR, we aim to remove the circular dependency issue in hilla from vaadin-platform.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 96.67% // Head: 96.67% // No change to project coverage 👍

Coverage data is based on head (a24f1fc) compared to base (5082811).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files          28       28           
  Lines        4659     4659           
  Branches      300      300           
=======================================
  Hits         4504     4504           
  Misses        152      152           
  Partials        3        3           
Flag Coverage Δ
unittests 96.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZheSun88
Copy link
Contributor Author

the error from the validation is

Stderr: 'vite v3.1.0 building for production...
Error:  transforming...
Error:  ✓ 103 modules transformed.
Error:  [vite]: Rollup failed to resolve import "@vaadin/field-base/src/field-mixin.js" from "node_modules/@vaadin/checkbox-group/src/vaadin-checkbox-group.js".

and there is a missing dependency in vaadin-checkbox-group, let us try this after the next web-component release.

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ZheSun88 ZheSun88 changed the title (WIP) resolve circular dependency chore: resolve circular dependency Oct 28, 2022
@ZheSun88 ZheSun88 merged commit a4e2809 into main Oct 28, 2022
@ZheSun88 ZheSun88 deleted the simplify-hilla-bom branch October 28, 2022 07:18
ZheSun88 added a commit that referenced this pull request Oct 28, 2022
* chore: resolve circular dependency

* chore: add lumo dependency

* chore: component view dependency

* chore: move component dependency to test root

* chore:add custom-field dependency
platosha pushed a commit that referenced this pull request Nov 9, 2022
* chore: resolve circular dependency  (#570)

* chore: resolve circular dependency

* chore: add lumo dependency

* chore: component view dependency

* chore: move component dependency to test root

* chore:add custom-field dependency

* chore: Make project work with latest Flow (#627)

* chore: update TB to latest

Co-authored-by: Artur <artur@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants