Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve circular dependency (#570) (CP: 1.3) #623

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Conversation

ZheSun88
Copy link
Contributor

  • chore: resolve circular dependency

  • chore: add lumo dependency

  • chore: component view dependency

  • chore: move component dependency to test root

  • chore:add custom-field dependency

* chore: resolve circular dependency

* chore: add lumo dependency

* chore: component view dependency

* chore: move component dependency to test root

* chore:add custom-field dependency
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 96.64% // Head: 96.67% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (bea130e) compared to base (a164bd3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.3     #623      +/-   ##
==========================================
+ Coverage   96.64%   96.67%   +0.02%     
==========================================
  Files          27       28       +1     
  Lines        4621     4659      +38     
  Branches      299      300       +1     
==========================================
+ Hits         4466     4504      +38     
  Misses        152      152              
  Partials        3        3              
Flag Coverage Δ
unittests 96.67% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...or-typescript-plugin-barrel/src/BarrelProcessor.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZheSun88
Copy link
Contributor Author

this will work after new WC 23.3.0.alpha has been released.

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@platosha platosha merged commit 05bfc9d into 1.3 Nov 9, 2022
@platosha platosha deleted the pick-570-1.3 branch November 9, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants