Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make project work with latest Flow #627

Merged
merged 2 commits into from
Nov 7, 2022
Merged

chore: Make project work with latest Flow #627

merged 2 commits into from
Nov 7, 2022

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Nov 7, 2022

No description provided.

@Artur- Artur- marked this pull request as ready for review November 7, 2022 07:24
@Artur- Artur- requested a review from platosha November 7, 2022 07:24
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 96.67% // Head: 96.67% // No change to project coverage 👍

Coverage data is based on head (fab11b2) compared to base (cc10e60).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files          28       28           
  Lines        4659     4659           
  Branches      300      300           
=======================================
  Hits         4504     4504           
  Misses        152      152           
  Partials        3        3           
Flag Coverage Δ
unittests 96.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@platosha platosha enabled auto-merge (squash) November 7, 2022 11:56
@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@platosha platosha merged commit de852bf into main Nov 7, 2022
@platosha platosha deleted the fix-compat branch November 7, 2022 12:30
platosha pushed a commit that referenced this pull request Nov 9, 2022
Co-authored-by: Artur <artur@vaadin.com>
platosha pushed a commit that referenced this pull request Nov 9, 2022
* chore: resolve circular dependency  (#570)

* chore: resolve circular dependency

* chore: add lumo dependency

* chore: component view dependency

* chore: move component dependency to test root

* chore:add custom-field dependency

* chore: Make project work with latest Flow (#627)

* chore: update TB to latest

Co-authored-by: Artur <artur@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants