Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform-flow-bundles version consistent test #4052

Closed
ZheSun88 opened this issue Apr 18, 2023 · 1 comment
Closed

platform-flow-bundles version consistent test #4052

ZheSun88 opened this issue Apr 18, 2023 · 1 comment
Assignees

Comments

@ZheSun88
Copy link
Contributor

ZheSun88 commented Apr 18, 2023

Describe your motivation

we have a few incident reports about inconsistency failure between
platform, flow and bundles version mismatch.

for example:
incident 1 : flow-platform #4024
incident 2 : platform-bundles different versions on vaadin-development-mode-detector
incident 3 : flow-bundles different versions on lit

for platform, all versions are recorded in versions.json
for flow, versions are recorded in several place, use this one for example
for bundles, versions are recorded in the package.json

Describe the solution you'd like

add a script to check all versions are aligned in different places.

maybe one of these three conditions should be considered:

  • for snapshot validation, check github branches about the referenced place
  • for PR validation, check the version used as dependency versions
  • for release, check the versions used as dependency versions

Describe alternatives you've considered

No response

Additional context

No response

@ZheSun88
Copy link
Contributor Author

I have added one test step to platform PR validation

  • check the bundles version is the same with component version
    • i.e: WebComponent version("24.1.0-alpha8") is not matching @vaadin/bundles version("24.1.0-alpha7")
  • check the version consistency between platform, flow and bundles, if not build will fail with message
    • i.e: Found different versions for @vaadin/router, platform:1.7.5 does not equal to flow:1.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant