Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @vaadin/router to 1.7.5 #16349

Merged
merged 3 commits into from
Mar 22, 2023
Merged

chore: update @vaadin/router to 1.7.5 #16349

merged 3 commits into from
Mar 22, 2023

Conversation

platosha
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 21, 2023

Test Results

   953 files  ±0     953 suites  ±0   57m 52s ⏱️ - 1m 53s
6 068 tests ±0  6 033 ✔️ ±0  35 💤 ±0  0 ±0 
6 318 runs  +1  6 276 ✔️ +1  42 💤 ±0  0 ±0 

Results for commit 40fee4c. ± Comparison against base commit 72ba97d.

♻️ This comment has been updated with latest results.

@Artur- Artur- enabled auto-merge (squash) March 22, 2023 07:56
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artur- Artur- merged commit ddf93c7 into main Mar 22, 2023
@Artur- Artur- deleted the chore/bump-router branch March 22, 2023 08:13
@vaadin-bot
Copy link
Collaborator

Hi @platosha and @Artur-, when i performed cherry-pick to this commit to 24.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick ddf93c7
error: could not apply ddf93c7... chore: update @vaadin/router to 1.7.5 (#16349)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mshabarov pushed a commit that referenced this pull request Mar 22, 2023
Co-authored-by: Anton Platonov <anton@vaadin.com>
@vaadin-bot
Copy link
Collaborator

Hi @platosha and @Artur-, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick ddf93c7
error: could not apply ddf93c7... chore: update @vaadin/router to 1.7.5 (#16349)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants