Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hilla module as a dependency to Platform #4934

Closed
mshabarov opened this issue Jan 22, 2024 · 4 comments
Closed

Add Hilla module as a dependency to Platform #4934

mshabarov opened this issue Jan 22, 2024 · 4 comments
Assignees

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Jan 22, 2024

Describe your motivation

Make com.vaadin:vaadin (or vaadin-core or vaadin-spring-boot-starter, to be discussed and researched) depend on the com.vaadin.hilla:hilla artifact, which includes the endpoint and engine-runtime, so if the hilla isn’t desired, one can exclude the whole hilla dependency.

Additional context

Vaadin/Hilla 24.4

@knoobie
Copy link
Contributor

knoobie commented Jan 22, 2024

Thanks for not adding it to vaadin-core :)

Edit: Damn :D

@mshabarov
Copy link
Contributor Author

Well, just changed it to vaadin-core :)
But indeed I'm not sure 100% what would be the best place for it.
Let me highlight it in the ticket.

@knoobie
Copy link
Contributor

knoobie commented Jan 22, 2024

5 seconds thought: Hilla requires Spring, therefore it should be in the spring starter as dependency? Vaadin and Vaadin Core does not require Spring

@mshabarov
Copy link
Contributor Author

mshabarov commented Jan 22, 2024

We cannot really add hilla to vaadin-core until we split react-components into core and all, as requested #4936.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants