You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add react-components-core (the name should be discussed, e.g. react-core-components or react-components-all) dependencies into Platform's version-core.json.
Flow then chooses between react or web-components package/dependency in generated package.json based on the reactRouterEnabled flag in Flow or auto-detection mechanism, see Include react-components into package.json flow#18506.
Additional context
Vaadin/Hilla 24.4.
The text was updated successfully, but these errors were encountered:
Remove the vaadin-core-versions.json files from hilla and hilla-react artifacts
platform vaadin-core-versions.json brings already hilla-react-components and flow should select the appropriate entries from here depending on the reactRouterEnabled flag or whatever
Describe your motivation
Vaadin react-components currently have no split to "core" and "commercial" parts like Vaadin web-components do.
That might lead to a problem of leaking commercial react components into an application that only imports
com.vaadin:vaadin-core
artifact.Acceptance Criteria:
version.json
with no split.package.json
, see Prototype splitting packages [2 days] react-components#229react-components-core
(the name should be discussed, e.g. react-core-components or react-components-all) dependencies into Platform'sversion-core.json
.package.json
based on thereactRouterEnabled
flag in Flow or auto-detection mechanism, see Include react-components into package.json flow#18506.Additional context
Vaadin/Hilla 24.4.
The text was updated successfully, but these errors were encountered: