Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vaadin react-component into version.json #4936

Closed
4 tasks done
mshabarov opened this issue Jan 22, 2024 · 1 comment
Closed
4 tasks done

Add Vaadin react-component into version.json #4936

mshabarov opened this issue Jan 22, 2024 · 1 comment

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Jan 22, 2024

Describe your motivation

Vaadin react-components currently have no split to "core" and "commercial" parts like Vaadin web-components do.

That might lead to a problem of leaking commercial react components into an application that only imports com.vaadin:vaadin-core artifact.

Acceptance Criteria:

  • Add react-components into Platform's version.json with no split.
  • React-components has a split to "core" and "commercial" components possible in the same way as web-components do, e.g. by having the license entry in the package.json, see Prototype splitting packages [2 days] react-components#229
  • Add react-components-core (the name should be discussed, e.g. react-core-components or react-components-all) dependencies into Platform's version-core.json.
  • Flow then chooses between react or web-components package/dependency in generated package.json based on the reactRouterEnabled flag in Flow or auto-detection mechanism, see Include react-components into package.json flow#18506.

Additional context

Vaadin/Hilla 24.4.

@manolo
Copy link
Member

manolo commented Jan 30, 2024

There is a missing task in the description

  • Remove the vaadin-core-versions.json files from hilla and hilla-react artifacts

platform vaadin-core-versions.json brings already hilla-react-components and flow should select the appropriate entries from here depending on the reactRouterEnabled flag or whatever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants