feat: reduce size of exported bundle from 1.5MB to 0.5MB #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manolo
force-pushed
the
gwt-optimize
branch
2 times, most recently
from
d287f20
to
ab1f373
Compare
manolo
changed the title
manolo
force-pushed
the
gwt-optimize
branch
2 times, most recently
from
6cfa162
to
2664ce4
Compare
manolo
commented
Apr 14, 2022
.../java/com/vaadin/spreadsheet/flowport/gwtexporter/OptimizedConnectorBundleLoaderFactory.java
Outdated
Show resolved
Hide resolved
manolo
commented
Apr 14, 2022
.../src/main/java/com/vaadin/spreadsheet/flowport/gwtexporter/ConnectorBundleLoaderFactory.java
Outdated
Show resolved
Hide resolved
manolo
commented
Apr 14, 2022
vaadin-spreadsheet-flow-client/src/main/java/com/vaadin/client/ApplicationConfiguration.java
Outdated
Show resolved
Hide resolved
alvarezguille
approved these changes
Apr 14, 2022
manolo
added a commit
to vaadin/flow-components
that referenced
this pull request
Apr 27, 2022
vaadin/spreadsheet#811 * feat: reduce size of exported bundle from 1.5MB to 0.5MB * chore: clean commented code and simplify optimized connector factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #810