fix: Spring Boot 2.6 compatibility

[Artur-]

Fixes #941

[ZheSun88]

do we need to update https://github.com/vaadin/spring/blob/master/pom.xml#L47 to spring-boot 2.6.0?

[Artur-]

This PR should be compatible with Spring Boot 2.4+. Maybe we should still update the version at the same time

[Artur-]

This fix could go into V22, we probably shouldn't go to Spring Boot 2.6 for that at this point

[Artur-]

Let's do the version update in #940

[knoobie]

The FQN defined in isSpringBootConfigured is probably faulty as well

[lmorocz]

And there is an extra org.springframework.boot.autoconfigure.web.ResourceProperties.class in the isSpringBootConfigured method as well.

[Artur-]

Simplified

[knoobie]

Is this class to be expected to work with plain spring or just spring boot?

[Artur-]

It is supposed to work with Spring. Seems like there are no proper tests for plain Spring projects in this repository

[Artur-]

Let's keep the untested code then and hope that it might work with plain Spring..

[knoobie]

I would like to have a more spring boot oriented implementation as well.. but I've seen multiple PRs in this repo in the past where explicitly a more complex route was taken to reduce the coupling with spring boot.. that's why I wanted to mention it

[haijian-vaadin]

could you @Artur- help to fix the sonar issue, let's get this merged soon

[mstahv]

I wouldn't care about Sonar issues at all, but Spring Boot 2.6.0 support for 22 would be cool ;-)

[knoobie]

^ for 14.6 as well 😀

[mstahv]

For 14 series as well yeah 👍

[vaadin-bot]

SonarQube analysis reported 2 issues

1. SpringVaadinServletService.java#L144: Either log or rethrow this exception.
2. SpringVaadinServletService.java#L175: Either log or rethrow this exception.

[Artur-]

Seems to work now, just waiting for a review

[vaadin-bot]

Hi @Artur- , this commit cannot be picked to 19.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 7589e30
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

[Artur-]

Seems like this is already in the 19.0 branch

[joheriks]

Seems like this is already in the 19.0 branch

There was no 19.0 branch at that point, created it after this commit.