Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't dispatch click event for disabled button #117

Closed
wants to merge 1 commit into from

Conversation

samiheikki
Copy link
Contributor

@samiheikki samiheikki commented Dec 13, 2018

Fixes #116


This change is Reviewable

/**
* @protected
*/
click() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be handled in vaadin-control-state-mixin repo, where the disabled state is managed.
It might be that someone would try to do the same with e.g. vaadin-checkbox and vaadin-radio-button.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@web-padawan
Copy link
Member

Closing in favour of vaadin/vaadin-control-state-mixin#49

@samiheikki samiheikki deleted the fix/click-disabled-button branch December 27, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants