Skip to content

Commit

Permalink
Move adding of the listeners to ready
Browse files Browse the repository at this point in the history
  • Loading branch information
yuriy-fix committed Aug 13, 2018
1 parent 68a6bed commit 8fb62d5
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions src/vaadin-checkbox-group.html
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,10 @@
];
}

/**
* @private
*/
connectedCallback() {
super.connectedCallback();
ready() {
super.ready();

this.setAttribute('role', 'checkboxgroup');

const checkedChangedListener = (e) => {
this._changeSelectedCheckbox(e.target);
Expand Down Expand Up @@ -199,12 +198,6 @@
});
}

ready() {
super.ready();

this.setAttribute('role', 'checkboxgroup');
}

/**
* Returns true if `value` is valid.
* `<iron-form>` uses this to check the validity or all its elements.
Expand Down

0 comments on commit 8fb62d5

Please sign in to comment.