Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the bundle for P3 components and size-limit check #177

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Apr 9, 2018

Fixes #176

Also added the size-limit to CI, in order to ensure that we match some (arbitrary) limit.
Current output looks like this:

  Package size: 192.33 KB
  Size limit:   200 KB

To run it locally, install the tool:

npm i -g size-limit

And then run it like this:

size-limit --why

This change is Reviewable

@tomivirkki
Copy link
Member

:lgtm: This is epic


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@web-padawan web-padawan merged commit 6e7bf29 into p3-preview Apr 10, 2018
@web-padawan web-padawan deleted the p3-preview-bundle branch April 10, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants