Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not prevent touchend for clear button #682

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Oct 14, 2019

Fixes #681


This change is Reviewable

@tomivirkki
Copy link
Member

This should also probably validate on a clear button tap so it would behave the same on mobile and desktop. Currently, if you have a required date-picker, it doesn't get marked as invalid if you clear the field on mobile.

@web-padawan
Copy link
Member Author

web-padawan commented Oct 14, 2019

Confirmed the regression (can be reproduced in Chrome mobile device emulation).

  • desktop:validate() for clear button is called for empty string (correct)

  • mobile: validate() for clear button is called for old value (incorrect).

So, we should call validate() in a different place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear button doesn't work on mobile
2 participants