Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min/max and i18n properties #4

Closed
tomivirkki opened this issue Sep 10, 2019 · 0 comments · Fixed by #19
Closed

Add min/max and i18n properties #4

tomivirkki opened this issue Sep 10, 2019 · 0 comments · Fixed by #19
Assignees
@Haprog

Comments

@tomivirkki
Copy link
Member

min (date + time, same format as value)
max (date + time, same format as value)
i18n {
...flattened values from both sub-components
}
@alvarezguille alvarezguille mentioned this issue Sep 24, 2019
Closed
Haprog added a commit that referenced this issue Nov 6, 2019
@Haprog
feat: add properties that can be forwarded to the sub-components
9dcd74d 
Implement support for the following properties:
- `label`
- `datePlaceholder`
- `timePlaceholder`
- `step`
- `initialPosition`
- `showWeekNumbers`: Note that this isn't actually useful until `i18n` is implemented since this only has an effect when `i18n.firstDayOfWeek` is set to `1` (Monday), see #4
- `disabled`
- `readonly`
This was referenced Nov 6, 2019
Merged
Closed
Haprog added a commit that referenced this issue Nov 26, 2019
@Haprog
feat: add properties that can be forwarded to the sub-components (#18)
6128899 
Implement support for the following properties:
- `label`
- `datePlaceholder`
- `timePlaceholder`
- `step`
- `initialPosition`
- `showWeekNumbers`: Note that this isn't actually useful until `i18n` is implemented since this only has an effect when `i18n.firstDayOfWeek` is set to `1` (Monday), see #4
- `disabled`
- `readonly`
@Haprog Haprog self-assigned this Nov 29, 2019
Haprog added a commit that referenced this issue Dec 16, 2019
@Haprog
feat: implement min and max properties (#4)
507d8f8
@Haprog Haprog mentioned this issue Dec 16, 2019
Merged
Haprog added a commit that referenced this issue Dec 19, 2019
@Haprog
feat: implement i18n property (#4)
0d71ece
Haprog added a commit that referenced this issue Jan 16, 2020
@Haprog
feat: implement min, max and i18n properties
577eb9b 
Merge pull request #19 from vaadin/feat/4-min-max-i18n
Closes #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Haprog Haprog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement min, max and i18n properties vaadin/vaadin-date-time-picker
2 participants
@Haprog @tomivirkki