Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to prevent auto enabling a component #79

Merged
merged 3 commits into from
Jan 24, 2019
Merged

Conversation

alexberazouski
Copy link

@alexberazouski alexberazouski commented Jan 24, 2019

Flow integration has to replicate the auto enable logic itself, in order to provide a way of keeping the component disabled after bad submission (too many failed attempts). Related #57


This change is Reviewable

@alexberazouski alexberazouski requested a review from a team January 24, 2019 12:54
@coveralls
Copy link

coveralls commented Jan 24, 2019

Coverage Status

Coverage increased (+0.02%) to 98.438% when pulling e5596e7 on set-error-fix into f85e80e on master.

Copy link
Contributor

@tulioag tulioag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@alvarezguille alvarezguille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@alvarezguille alvarezguille merged commit 95eca47 into master Jan 24, 2019
@alvarezguille alvarezguille deleted the set-error-fix branch January 24, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants