Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only add vaadin-tab elements to items #151

Merged
merged 2 commits into from
Jan 23, 2020
Merged

fix: only add vaadin-tab elements to items #151

merged 2 commits into from
Jan 23, 2020

Conversation

web-padawan
Copy link
Member

Fixes #150

@web-padawan web-padawan merged commit 7359f6d into next Jan 23, 2020
@web-padawan web-padawan deleted the fix-items branch January 23, 2020 08:54
@tomivirkki
Copy link
Member

Hmm...shouldn't this rather filter all children by child instanceOf VaadinTab similarly to what the previous major did? New Tabs would ignore VaadinTab extensions that have a tag name different from "vaadin-tab" (not sure if this is a big problem).

@web-padawan
Copy link
Member Author

Anyone who wants to extend VaadinTab is free to also override _filterItems method.

We can re-introduce this check though. There is already hasSelectedStateMixin that can be used for this purpose. Would it be better to use that here? @tomivirkki WDYT?

@moderndeveloperllc
Copy link

moderndeveloperllc commented Feb 4, 2020

@web-padawan
Copy link
Member Author

web-padawan commented Feb 4, 2020

@moderndeveloperllc actually, it might be good idea to export that function from there.

Or maybe I rather override that protected method in this mixin directly.

@web-padawan
Copy link
Member Author

Submitted vaadin/component-mixins#43 to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.x] Non-selectable items are now included in the vaadin-tabs "items" array
4 participants