-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fire a validated event on validation (CP: 14) #614
Conversation
test/email-field-validation.html
Outdated
</head> | ||
|
||
<body> | ||
<test-fixture id="default"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could be basic
to be in line with the basic
test suite.
<test-fixture id="default"> | |
<test-fixture id="basic"> |
const isValid = this.checkValidity(); | ||
this.invalid = !isValid; | ||
this.dispatchEvent(new CustomEvent('validated', {detail: {valid: isValid}})); | ||
return isValid; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we've missed this JSDoc:
It needs to be added for the event to show up in the API documentation.
Description
Backports the following PRs:
validated
event on validation web-components#4084Part of vaadin/web-components#5763