Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fire a validated event on validation (CP: 14) #614

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

mukherjeesudebi
Copy link
Contributor

@mukherjeesudebi mukherjeesudebi commented Apr 5, 2023

</head>

<body>
<test-fixture id="default">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could be basic to be in line with the basic test suite.

Suggested change
<test-fixture id="default">
<test-fixture id="basic">

@vursen vursen changed the title feat: fire a validated event on validation feat: fire a validated event on validation (CP: 14) Apr 17, 2023
@vursen vursen merged commit 3eb1b2e into master Apr 17, 2023
@vursen vursen deleted the backport-validated-event branch April 17, 2023 08:35
const isValid = this.checkValidity();
this.invalid = !isValid;
this.dispatchEvent(new CustomEvent('validated', {detail: {valid: isValid}}));
return isValid;
}
Copy link
Contributor

@vursen vursen Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we've missed this JSDoc:

https://github.com/vaadin/web-components/pull/4084/files#diff-ce25fa3626d29f442b1b98935ad7c0909865efc4375789d17e1f7b3b18fe392dR34-R40

It needs to be added for the event to show up in the API documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants