Skip to content

Commit 0bf1c27

Browse files
authored
refactor: update grid borders base styles custom properties (#10212)
1 parent a3876e6 commit 0bf1c27

File tree

88 files changed

+163
-76
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+163
-76
lines changed

dev/playground/grid-pro.html

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,14 @@
3838
vaadin-grid-pro.max-height {
3939
max-height: 250px;
4040
}
41+
42+
vaadin-grid-pro[theme~="no-row-borders"] {
43+
--vaadin-grid-row-border-width: 0px;
44+
}
45+
46+
vaadin-grid-pro[theme~="column-borders"] {
47+
--vaadin-grid-column-border-width: 1px;
48+
}
4149
</style>
4250
</head>
4351
<body>
@@ -67,16 +75,18 @@
6775
<vaadin-select id="textAlign" label="Text Align"></vaadin-select>
6876
</div>
6977

70-
<div class="control-group">
71-
<vaadin-checkbox-group label="Theme Variants">
78+
<div class="control-group theme-variants">
79+
<vaadin-checkbox-group label="Built-In Variants">
7280
<vaadin-checkbox value="no-border" label="No Border"></vaadin-checkbox>
73-
<vaadin-checkbox value="no-row-borders" label="No Row Border"></vaadin-checkbox>
74-
<vaadin-checkbox value="column-borders" label="Column Borders"></vaadin-checkbox>
7581
<vaadin-checkbox value="row-stripes" label="Row Stripes"></vaadin-checkbox>
7682
<vaadin-checkbox value="wrap-cell-content" label="Wrap Cell Content"></vaadin-checkbox>
7783
<vaadin-checkbox value="highlight-editable-cells" label="Highlight Editable Cells"></vaadin-checkbox>
7884
<vaadin-checkbox value="highlight-read-only-cells" label="Highlight Read-Only Cells"></vaadin-checkbox>
7985
</vaadin-checkbox-group>
86+
<vaadin-checkbox-group label="Custom Variants">
87+
<vaadin-checkbox value="no-row-borders" label="No Row Border"></vaadin-checkbox>
88+
<vaadin-checkbox value="column-borders" label="Column Borders"></vaadin-checkbox>
89+
</vaadin-checkbox-group>
8090
</div>
8191

8292
<div class="control-group">
@@ -257,7 +267,7 @@ <h4>Details for ${model.item.name}</h4>
257267
});
258268

259269
// Theme Controls
260-
document.querySelectorAll('[label="Theme Variants"] vaadin-checkbox').forEach((control) => {
270+
document.querySelectorAll('.theme-variants vaadin-checkbox').forEach((control) => {
261271
control.addEventListener('checked-changed', (e) => {
262272
if (e.detail.value) {
263273
grid.setAttribute('theme', `${grid.getAttribute('theme') || ''} ${control.value}`.trim());

dev/playground/grid.html

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,14 @@
4242
vaadin-grid[theme~="row-hover"] {
4343
--vaadin-grid-row-hover-background-color: hsla(0deg, 0%, 0%, 0.03);
4444
}
45+
46+
vaadin-grid[theme~="no-row-borders"] {
47+
--vaadin-grid-row-border-width: 0px;
48+
}
49+
50+
vaadin-grid[theme~="column-borders"] {
51+
--vaadin-grid-column-border-width: 1px;
52+
}
4553
</style>
4654
</head>
4755
<body>
@@ -78,12 +86,12 @@
7886
<div class="control-group">
7987
<vaadin-checkbox-group label="Built-In Variants">
8088
<vaadin-checkbox id="no-border" value="no-border" label="No Border"></vaadin-checkbox>
81-
<vaadin-checkbox id="no-row-borders" value="no-row-borders" label="No Row Border"></vaadin-checkbox>
82-
<vaadin-checkbox id="column-borders" value="column-borders" label="Column Borders"></vaadin-checkbox>
83-
<vaadin-checkbox id="row-stripes" value="row-stripes" label="Row Stripes"></vaadin-checkbox>
8489
<vaadin-checkbox id="wrap-cell-content" value="wrap-cell-content" label="Wrap Cell Content"></vaadin-checkbox>
90+
<vaadin-checkbox id="row-stripes" value="row-stripes" label="Row Stripes"></vaadin-checkbox>
8591
</vaadin-checkbox-group>
8692
<vaadin-checkbox-group label="Custom Variants">
93+
<vaadin-checkbox id="no-row-borders" value="no-row-borders" label="No Row Border"></vaadin-checkbox>
94+
<vaadin-checkbox id="column-borders" value="column-borders" label="Column Borders"></vaadin-checkbox>
8795
<vaadin-checkbox id="row-hover" value="row-hover" label="Row Hover"></vaadin-checkbox>
8896
</vaadin-checkbox-group>
8997
</div>
20 Bytes
Loading
15 Bytes
Loading
42 Bytes
Loading
15 Bytes
Loading
47 Bytes
Loading
14 Bytes
Loading
-93 Bytes
Loading
-89 Bytes
Loading

0 commit comments

Comments
 (0)