test: remove target arg from nextRender helper calls (#9246)

Author: DiegoCardoso

packages/avatar-group/test/avatar-group.test.js

@@ -40,7 +40,7 @@ describe('avatar-group', () => {
   describe('items property', () => {
     beforeEach(async () => {
       group.items = [{ abbr: 'PM' }, { name: 'Yuriy Yevstihnyeyev' }, { abbr: 'SK' }, { name: 'Jens Jansson' }];
-      await nextRender(group);
+      await nextRender();
     });
 
     it('should render avatar for each item, plus overflow avatar', () => {
@@ -84,7 +84,7 @@ describe('avatar-group', () => {
     beforeEach(async () => {
       group.items = [{ abbr: 'PM' }, { name: 'Yuriy Yevstihnyeyev' }, { name: 'Serhii Kulykov' }, { abbr: 'JJ' }, {}];
       group.maxItemsVisible = 3;
-      await nextRender(group);
+      await nextRender();
     });
 
     it('should render avatar based on maxItemsVisible, including overflow avatar', () => {
@@ -112,63 +112,63 @@ describe('avatar-group', () => {
 
     it('should show at least two avatars if maxItemsVisible is below 2', async () => {
       group.maxItemsVisible = 1;
-      await nextRender(group);
+      await nextRender();
       const items = group.querySelectorAll('vaadin-avatar');
       expect(items.length).to.equal(2);
     });
 
     it('should set abbr property correctly if maxItemsVisible is below 2', async () => {
       group.maxItemsVisible = 1;
-      await nextRender(group);
+      await nextRender();
       const overflow = group._overflow;
       expect(overflow.abbr).to.equal('+4');
     });
 
     it('should show two avatars if maxItemsVisible is below 2', async () => {
       group.items = group.items.slice(0, 2);
       group.maxItemsVisible = 1;
-      await nextRender(group);
+      await nextRender();
       const items = group.querySelectorAll('vaadin-avatar:not([hidden])');
       expect(items.length).to.equal(2);
     });
 
     it('should hide overflow avatar when maxItemsVisible property is set to null', async () => {
       group.maxItemsVisible = null;
-      await nextRender(group);
+      await nextRender();
       expect(group._overflow.hasAttribute('hidden')).to.be.true;
     });
 
     it('should hide overflow avatar when maxItemsVisible property is set to undefined', async () => {
       group.maxItemsVisible = undefined;
-      await nextRender(group);
+      await nextRender();
       expect(group._overflow.hasAttribute('hidden')).to.be.true;
     });
 
     it('should hide overflow avatar when items property is changed', async () => {
       group.maxItemsVisible = 2;
-      await nextRender(group);
+      await nextRender();
       group.items = group.items.slice(0, 2);
-      await nextRender(group);
+      await nextRender();
       expect(group._overflow.hasAttribute('hidden')).to.be.true;
     });
 
     // https://github.com/vaadin/vaadin-avatar/issues/83
     it('should show only maxItemsVisible when setting items after being empty', async () => {
       const maxItemsVisible = 3;
       group.maxItemsVisible = maxItemsVisible;
-      await nextRender(group);
+      await nextRender();
       const items = group.items;
       group.items = [];
       group.items = items;
-      await nextRender(group);
+      await nextRender();
       const renderedElements = group.querySelectorAll('vaadin-avatar');
       expect(renderedElements.length).to.equal(maxItemsVisible);
     });
 
     describe('width is set', () => {
       beforeEach(async () => {
         group.maxItemsVisible = 4;
-        await nextRender(group);
+        await nextRender();
       });
 
       it('should consider element width when maxItemsVisible is set', async () => {
@@ -194,7 +194,7 @@ describe('avatar-group', () => {
 
     beforeEach(async () => {
       group.items = [{ abbr: '01' }, { abbr: '02' }, { abbr: '03' }, { abbr: '04' }, { abbr: '05' }];
-      await nextRender(group);
+      await nextRender();
       overlay = group.$.overlay;
       overflow = group._overflow;
     });
@@ -278,7 +278,7 @@ describe('avatar-group', () => {
         { name: 'Jens Jansson' },
       ];
       group.maxItemsVisible = 2;
-      await nextRender(group);
+      await nextRender();
       overlay = group.$.overlay;
       overflow = group._overflow;
     });
@@ -405,7 +405,7 @@ describe('avatar-group', () => {
         { name: 'Yuriy Yevstihnyeyev', colorIndex: 1 },
         { name: 'Serhii Kulykov', colorIndex: 2 },
       ];
-      await nextRender(group);
+      await nextRender();
       overlay = group.$.overlay;
       overflow = group._overflow;
     });
@@ -438,7 +438,7 @@ describe('avatar-group', () => {
         { name: 'Yuriy Yevstihnyeyev', className: 'bar' },
         { name: 'Serhii Kulykov', className: 'baz' },
       ];
-      await nextRender(group);
+      await nextRender();
       overlay = group.$.overlay;
       overflow = group._overflow;
     });
@@ -475,7 +475,7 @@ describe('avatar-group', () => {
 
     beforeEach(async () => {
       group.items = [{ abbr: 'PM' }, { name: 'Yuriy Yevstihnyeyev' }, { name: 'Serhii Kulykov' }];
-      await nextRender(group);
+      await nextRender();
       overlay = group.$.overlay;
       overflow = group._overflow;
     });
@@ -535,7 +535,7 @@ describe('avatar-group', () => {
         { name: 'Jens Jansson' },
       ];
       group.maxItemsVisible = 2;
-      await nextRender(group);
+      await nextRender();
       overlay = group.$.overlay;
       overflow = group._overflow;
     });
@@ -563,7 +563,7 @@ describe('avatar-group', () => {
 
     beforeEach(async () => {
       group.items = [{ name: 'AA' }, { name: 'BB' }, { name: 'CC' }];
-      await nextRender(group);
+      await nextRender();
       clock = sinon.useFakeTimers();
     });
 
@@ -639,7 +639,7 @@ describe('avatar group in column flex', () => {
       { abbr: 'LA' },
       { name: 'Jens Jansson' },
     ];
-    await nextRender(group);
+    await nextRender();
   });
 
   it('should have width of the parent', () => {

packages/avatar-group/test/visual/lumo/avatar-group.test.js

@@ -65,9 +65,9 @@ describe('avatar-group', () => {
     document.body.style.width = '220px';
     element.maxItemsVisible = 3;
     element.items = [{ name: 'Abc Def' }, { name: 'Ghi Jkl' }, { name: 'Mno Pqr' }, { name: 'Stu Vwx' }];
-    await nextRender(element);
+    await nextRender();
     element._overflow.click();
-    await nextRender(element);
+    await nextRender();
     await visualDiff(document.body, 'opened');
   });
 

packages/button/test/button.test.ts

@@ -29,7 +29,7 @@ describe('vaadin-button', () => {
     describe('default', () => {
       beforeEach(async () => {
         button = fixtureSync('<vaadin-button>Press me</vaadin-button>');
-        await nextRender(button);
+        await nextRender();
       });
 
       it('should set role attribute to button by default', () => {
@@ -40,7 +40,7 @@ describe('vaadin-button', () => {
     describe('custom', () => {
       beforeEach(async () => {
         button = fixtureSync('<vaadin-button role="menuitem">Press me</vaadin-button>');
-        await nextRender(button);
+        await nextRender();
       });
 
       it('should not override custom role attribute', () => {
@@ -52,7 +52,7 @@ describe('vaadin-button', () => {
   describe('keyboard', () => {
     beforeEach(async () => {
       button = fixtureSync('<vaadin-button>Press me</vaadin-button>');
-      await nextRender(button);
+      await nextRender();
       button.focus();
     });
 
@@ -129,7 +129,7 @@ describe('vaadin-button', () => {
           <input id="last-global-focusable" />
         </div>`,
       ).children as unknown as [Button, HTMLInputElement];
-      await nextRender(button);
+      await nextRender();
     });
 
     afterEach(async () => {
@@ -181,7 +181,7 @@ describe('vaadin-button', () => {
           <input id="last-global-focusable" />
         </div>`,
       ).children as unknown as [Button, HTMLInputElement];
-      await nextRender(button);
+      await nextRender();
     });
 
     afterEach(async () => {

packages/card/test/accessibility.test.js

@@ -10,7 +10,7 @@ describe('accessibility', () => {
 
   beforeEach(async () => {
     card = fixtureSync('<vaadin-card></vaadin-card>');
-    await nextRender(card);
+    await nextRender();
   });
 
   describe('ARIA roles', () => {
@@ -35,7 +35,7 @@ describe('accessibility', () => {
       await nextUpdate(card);
       const customTitleElement = fixtureSync('<span slot="title">Custom title element</span>');
       card.appendChild(customTitleElement);
-      await nextRender(card);
+      await nextRender();
       expect(card.hasAttribute('aria-labelledby')).to.be.false;
     });
   });

packages/card/test/card.test.ts

@@ -43,7 +43,7 @@ describe('vaadin-card', () => {
     it('should create title element with default aria-level when title property is set', async () => {
       const stringTitle = 'Some title';
       card.cardTitle = stringTitle;
-      await nextRender(card);
+      await nextRender();
       const stringTitleElement = getStringTitleElement();
       expect(stringTitleElement).to.exist;
       expect(stringTitleElement.getAttribute('aria-level')).to.equal('2');
@@ -53,7 +53,7 @@ describe('vaadin-card', () => {
     it('should update aria-level when heading level changes', async () => {
       card.cardTitle = 'Some title';
       card.titleHeadingLevel = 3;
-      await nextRender(card);
+      await nextRender();
       const stringTitleElement = getStringTitleElement();
       expect(stringTitleElement.getAttribute('aria-level')).to.equal('3');
     });
@@ -62,43 +62,43 @@ describe('vaadin-card', () => {
       card.titleHeadingLevel = 3;
       card.cardTitle = 'Some title';
       card.titleHeadingLevel = null;
-      await nextRender(card);
+      await nextRender();
       expect(getStringTitleElement().getAttribute('aria-level')).to.equal('2');
     });
 
     it('should clear string title when custom title element is used', async () => {
       card.cardTitle = 'Some title';
-      await nextRender(card);
+      await nextRender();
       const customTitleElement = fixtureSync('<span slot="title">Custom title element</span>');
       card.appendChild(customTitleElement);
-      await nextRender(card);
+      await nextRender();
       expect(card.cardTitle).to.be.not.ok;
       expect(getStringTitleElement()).to.not.exist;
     });
 
     it('should clear string title when empty string title is set', async () => {
       card.cardTitle = 'Some title';
-      await nextRender(card);
+      await nextRender();
       card.cardTitle = '';
-      await nextRender(card);
+      await nextRender();
       expect(getStringTitleElement()).to.not.exist;
     });
 
     it('should clear custom title element when string title is set', async () => {
       const customTitleElement = fixtureSync('<span slot="title">Custom title element</span>');
       card.appendChild(customTitleElement);
-      await nextRender(card);
+      await nextRender();
       card.cardTitle = 'Some title';
-      await nextRender(card);
+      await nextRender();
       expect(getCustomTitleElement()).to.not.exist;
     });
 
     it('should not clear custom title element when empty string title is set', async () => {
       const customTitleElement = fixtureSync('<span slot="title">Custom title element</span>');
       card.appendChild(customTitleElement);
-      await nextRender(card);
+      await nextRender();
       card.cardTitle = '';
-      await nextRender(card);
+      await nextRender();
       expect(getCustomTitleElement()).to.exist;
     });
   });

packages/charts/test/chart-series.test.js

@@ -96,33 +96,33 @@ describe('vaadin-chart-series', () => {
 
       it('should have markers by default for widespread data', async () => {
         series.values = [10, 20, 10, 30, 50];
-        await nextRender(chart);
+        await nextRender();
         expect(markersVisible(chartContainer)).to.be.true;
       });
 
       it('should not have markers by default for dense data', async () => {
         series.values = new Array(400).fill(10);
-        await nextRender(chart);
+        await nextRender();
         expect(markersVisible(chartContainer)).to.be.false;
       });
 
       it('should have markers when set to shown', async () => {
         series.markers = 'shown';
         series.values = new Array(400).fill(10);
-        await nextRender(chart);
+        await nextRender();
         expect(markersVisible(chartContainer)).to.be.true;
       });
 
       it('should not have markers when set to hidden', async () => {
         series.markers = 'hidden';
         series.values = [10, 20, 10, 30, 50];
-        await nextRender(chart);
+        await nextRender();
         expect(markersVisible(chartContainer)).to.be.false;
       });
 
       it('should not have markers when options are set', async () => {
         series.values = [10, 20, 10, 30, 50];
-        await nextRender(chart);
+        await nextRender();
         chart.additionalOptions = { plotOptions: { series: { marker: { enabled: false } } } };
         await aTimeout(50);
         expect(markersVisible(chartContainer)).to.be.false;

packages/charts/test/exporting.test.js

@@ -57,7 +57,7 @@ describe('vaadin-chart exporting', () => {
     pngExportButton.onclick();
 
     expect(fireEventSpy.firstCall.args[1]).to.be.equal('beforeExport');
-    await nextRender(chart);
+    await nextRender();
     expect(styleCopiedToBody).to.be.true;
     expect(styleContent).to.include('.highcharts-color-0');
   });
@@ -85,7 +85,7 @@ describe('vaadin-chart exporting', () => {
     pngExportButton.onclick();
 
     expect(fireEventSpy.lastCall.args[1]).to.be.equal('afterExport');
-    await nextRender(chart);
+    await nextRender();
     expect(styleRemovedFromBody).to.be.true;
   });
 
@@ -116,7 +116,7 @@ describe('vaadin-chart exporting', () => {
     pngExportButton.onclick();
 
     expect(fireEventSpy.lastCall.args[1]).to.be.equal('afterExport');
-    await nextRender(chart);
+    await nextRender();
     expect(styledModeAddedToBody).to.be.true;
     expect(document.body.hasAttribute(attributeName)).to.be.false;
   });
@@ -148,7 +148,7 @@ describe('vaadin-chart exporting', () => {
     pngExportButton.onclick();
 
     expect(fireEventSpy.lastCall.args[1]).to.be.equal('afterExport');
-    await nextRender(chart);
+    await nextRender();
     expect(styledModeAddedToBody).to.be.false;
     expect(document.body.hasAttribute(attributeName)).to.be.false;
   });