refactor: remove obsolete animation on infinite scroller (#9139)

Author: vursen

packages/date-picker/src/vaadin-infinite-scroller.js

@@ -41,16 +41,6 @@ template.innerHTML = `
       box-sizing: border-box;
       padding-right: 40px;
       top: var(--vaadin-infinite-scroller-buffer-offset, 0);
-      animation: fadein 0.2s;
-    }
-
-    @keyframes fadein {
-      from {
-        opacity: 0;
-      }
-      to {
-        opacity: 1;
-      }
     }
   </style>
 

packages/date-picker/test/visual/lumo/date-picker.test.js

@@ -4,6 +4,7 @@ import { visualDiff } from '@web/test-runner-visual-regression';
 import '../../not-animated-styles.js';
 import '../common.js';
 import '../../../theme/lumo/vaadin-date-picker.js';
+import { untilOverlayRendered } from '../../helpers.js';
 
 describe('date-picker', () => {
   let div, element;
@@ -101,23 +102,24 @@ describe('date-picker', () => {
       });
 
       describe('dropdown', () => {
-        function openOverlay() {
+        async function openOverlay() {
           element.opened = true;
           div.style.height = `${element.offsetHeight + element.$.overlay.$.overlay.offsetHeight}px`;
           div.style.width = `${element.$.overlay.$.overlay.offsetWidth}px`;
+          await untilOverlayRendered(element);
         }
 
         it('default', async () => {
           element.value = '2000-01-01';
-          openOverlay();
+          await openOverlay();
           await visualDiff(div, `${dir}-dropdown`);
         });
 
         it('week numbers', async () => {
           element.value = '2000-01-01';
           element.showWeekNumbers = true;
           element.i18n = { firstDayOfWeek: 1 };
-          openOverlay();
+          await openOverlay();
           await visualDiff(div, `${dir}-week-numbers`);
         });
       });

packages/date-picker/test/visual/lumo/screenshots/date-picker/baseline/ltr-dropdown.png

@@ -4,6 +4,7 @@ import { visualDiff } from '@web/test-runner-visual-regression';
 import '../../not-animated-styles.js';
 import '../common.js';
 import '../../../theme/material/vaadin-date-picker.js';
+import { untilOverlayRendered } from '../../helpers.js';
 
 describe('date-picker', () => {
   let div, element;
@@ -100,23 +101,24 @@ describe('date-picker', () => {
       });
 
       describe('dropdown', () => {
-        function openOverlay() {
+        async function openOverlay() {
           element.opened = true;
           div.style.height = `${element.offsetHeight + element.$.overlay.$.overlay.offsetHeight}px`;
           div.style.width = `${element.$.overlay.$.overlay.offsetWidth}px`;
+          await untilOverlayRendered(element);
         }
 
         it('default', async () => {
           element.value = '2000-01-01';
-          openOverlay();
+          await openOverlay();
           await visualDiff(div, `${dir}-dropdown`);
         });
 
         it('week numbers', async () => {
           element.value = '2000-01-01';
           element.showWeekNumbers = true;
           element.i18n = { firstDayOfWeek: 1 };
-          openOverlay();
+          await openOverlay();
           await visualDiff(div, `${dir}-week-numbers`);
         });
       });