Skip to content

Commit 92b6bc9

Browse files
authored
refactor: remove no longer needed contained theme from buttons (#9275)
1 parent 9e966f5 commit 92b6bc9

File tree

5 files changed

+14
-19
lines changed

5 files changed

+14
-19
lines changed

packages/login/src/vaadin-login-form.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,7 @@ class LoginForm extends LoginFormMixin(ElementMixin(ThemableMixin(PolylitMixin(L
116116
</vaadin-password-field>
117117
</form>
118118
119-
<vaadin-button
120-
slot="submit"
121-
theme="primary contained submit"
122-
@click="${this.submit}"
123-
.disabled="${this.disabled}"
124-
>
119+
<vaadin-button slot="submit" theme="primary submit" @click="${this.submit}" .disabled="${this.disabled}">
125120
${this.__effectiveI18n.form.submit}
126121
</vaadin-button>
127122

packages/login/test/dom/__snapshots__/login-form.test.snap.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ snapshots["vaadin-login-form host default"] =
9595
role="button"
9696
slot="submit"
9797
tabindex="0"
98-
theme="primary contained submit"
98+
theme="primary submit"
9999
>
100100
Log in
101101
</vaadin-button>
@@ -214,7 +214,7 @@ snapshots["vaadin-login-form host required"] =
214214
role="button"
215215
slot="submit"
216216
tabindex="0"
217-
theme="primary contained submit"
217+
theme="primary submit"
218218
>
219219
Log in
220220
</vaadin-button>
@@ -325,7 +325,7 @@ snapshots["vaadin-login-form host i18n"] =
325325
role="button"
326326
slot="submit"
327327
tabindex="0"
328-
theme="primary contained submit"
328+
theme="primary submit"
329329
>
330330
Kirjaudu sisään
331331
</vaadin-button>
@@ -436,7 +436,7 @@ snapshots["vaadin-login-form host i18n-partial"] =
436436
role="button"
437437
slot="submit"
438438
tabindex="0"
439-
theme="primary contained submit"
439+
theme="primary submit"
440440
>
441441
Log in
442442
</vaadin-button>
@@ -555,7 +555,7 @@ snapshots["vaadin-login-form host i18n-required"] =
555555
role="button"
556556
slot="submit"
557557
tabindex="0"
558-
theme="primary contained submit"
558+
theme="primary submit"
559559
>
560560
Kirjaudu sisään
561561
</vaadin-button>
@@ -666,7 +666,7 @@ snapshots["vaadin-login-form host noForgotPassword"] =
666666
role="button"
667667
slot="submit"
668668
tabindex="0"
669-
theme="primary contained submit"
669+
theme="primary submit"
670670
>
671671
Log in
672672
</vaadin-button>

packages/login/test/dom/__snapshots__/login-overlay.test.snap.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ snapshots["vaadin-login-overlay host default"] =
109109
role="button"
110110
slot="submit"
111111
tabindex="0"
112-
theme="primary contained submit"
112+
theme="primary submit"
113113
>
114114
Log in
115115
</vaadin-button>
@@ -235,7 +235,7 @@ snapshots["vaadin-login-overlay host i18n"] =
235235
role="button"
236236
slot="submit"
237237
tabindex="0"
238-
theme="primary contained submit"
238+
theme="primary submit"
239239
>
240240
Kirjaudu sisään
241241
</vaadin-button>
@@ -361,7 +361,7 @@ snapshots["vaadin-login-overlay host i18n-partial"] =
361361
role="button"
362362
slot="submit"
363363
tabindex="0"
364-
theme="primary contained submit"
364+
theme="primary submit"
365365
>
366366
Log in
367367
</vaadin-button>
@@ -488,7 +488,7 @@ snapshots["vaadin-login-overlay host overlay class"] =
488488
role="button"
489489
slot="submit"
490490
tabindex="0"
491-
theme="primary contained submit"
491+
theme="primary submit"
492492
>
493493
Log in
494494
</vaadin-button>

packages/message-input/src/vaadin-message-input-mixin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export const MessageInputMixin = (superClass) =>
9292

9393
this._buttonController = new SlotController(this, 'button', 'vaadin-button', {
9494
initializer: (btn) => {
95-
btn.setAttribute('theme', 'primary contained');
95+
btn.setAttribute('theme', 'primary');
9696

9797
btn.addEventListener('click', () => {
9898
this.__submit();

packages/message-input/test/dom/__snapshots__/message-input.test.snap.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ snapshots["vaadin-message-input default"] =
77
role="button"
88
slot="button"
99
tabindex="0"
10-
theme="primary contained"
10+
theme="primary"
1111
>
1212
Send
1313
</vaadin-button>
@@ -48,7 +48,7 @@ snapshots["vaadin-message-input disabled"] =
4848
role="button"
4949
slot="button"
5050
tabindex="-1"
51-
theme="primary contained"
51+
theme="primary"
5252
>
5353
Send
5454
</vaadin-button>

0 commit comments

Comments
 (0)