Skip to content

Commit dfd6ad0

Browse files
authored
fix: aura rendering performance improvements (#10248)
1 parent 14a0ede commit dfd6ad0

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

dev/aura.html

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,11 @@
239239
--icon-rotate-ccw: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="1.75" stroke-linecap="round" stroke-linejoin="round"><path d="M3 12a9 9 0 1 0 9-9 9.75 9.75 0 0 0-6.74 2.74L3 8"/><path d="M3 3v5h5"/></svg>');
240240
}
241241

242+
html, body, vaadin-app-layout {
243+
margin: 0;
244+
height: 100%;
245+
}
246+
242247
/* TODO re-evaluate MDL API, how to achieve this */
243248
.dashboard-section::part(master) {
244249
flex-basis: 15em;

packages/aura/src/color.css

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,10 @@
3636
color-mix(in srgb, var(--_border-color-base) max(6%, 5% + 5% * var(--aura-contrast)), transparent)
3737
);
3838

39-
--aura-background-light: oklch(from var(--aura-accent-light) min(1, l + (1 - l) * 0.9) calc(c * 0.05) h);
40-
--aura-background-dark: oklch(from var(--aura-accent-dark) max(0, l/2 - (1 - l) * 0.2) calc(c * 0.05) h);
39+
/* Using static values (vs relative colors) for these backgrounds improves first paint rendering performance quite much (~200ms) */
40+
--aura-background-light: oklch(95% 0.005 260);
41+
--aura-background-dark: oklch(20% 0.01 260);
42+
4143
--aura-background: light-dark(var(--aura-background-light), var(--aura-background-dark));
4244

4345
--_bg-alt: oklch(
@@ -46,13 +48,14 @@
4648
--_bg-accent: radial-gradient(
4749
circle at 0% 0%,
4850
light-dark(
49-
oklch(from var(--aura-background-light) min(1, l + c * 3) min(c, c * 3 - l/20) h),
51+
oklch(from var(--aura-background-light) min(1, l + c * 3) min(c, c * 3) h),
5052
oklch(from var(--aura-background-dark) min(1, l + c) clamp(0, c * 1.5, 0.4) h)
5153
),
5254
transparent 30%
5355
);
5456
--aura-app-background:
55-
var(--_bg-accent), radial-gradient(circle at 25% 0% in xyz, var(--aura-background) 33%, var(--_bg-alt));
57+
var(--_bg-accent),
58+
radial-gradient(circle at 25% 0% in xyz, var(--aura-background) 33%, var(--_bg-alt)) var(--aura-background);
5659

5760
--aura-accent-color: light-dark(var(--aura-accent-light), var(--aura-accent-dark));
5861
--vaadin-focus-ring-color: var(--aura-accent-color);

packages/aura/src/components/app-layout.css

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,6 @@
1616
}
1717
}
1818

19-
html:has(vaadin-app-layout) {
20-
&,
21-
body {
22-
width: 100%;
23-
height: 100%;
24-
margin: 0;
25-
box-sizing: border-box;
26-
}
27-
}
28-
2919
vaadin-app-layout {
3020
--_app-layout-radius: clamp(0px, var(--aura-app-layout-radius), var(--aura-app-layout-inset) * 100);
3121
padding-block: var(--aura-app-layout-inset);

0 commit comments

Comments
 (0)