fix: reset background for menu-bar item in button #2967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported by @jouni at #2955 (comment), moving styles caused a regression in Menu Bar styles.
This is what happens on hover when
item.component
is used e.g. to provide custom icon:Caused by the following style (same also happens in Material theme):
web-components/packages/item/theme/lumo/vaadin-item-styles.js
Lines 67 to 69 in c2d88fd
Type of change