Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend clickable area to handle clicks as expected #3327

Merged
merged 6 commits into from
Jan 24, 2022

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jan 21, 2022

Description

Changed <div class="vaadin-radio-button-container"> to be display: grid - this enables setting height: 100% on the <div class="vaadin-radio-button-wrapper"> work and also makes slotted <label> take the full width.

Fixes #3324

Type of change

  • Bugfix

@web-padawan web-padawan changed the title fix: forward radio-button container click fix: extend clickable area to handle clicks as expected Jan 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha4 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[radio-button-group] Shorter label don't register click
4 participants