Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add map component behind a feature flag #3341

Merged
merged 8 commits into from
Jan 25, 2022
Merged

feat: add map component behind a feature flag #3341

merged 8 commits into from
Jan 25, 2022

Conversation

sissbruecker
Copy link
Contributor

Description

Adds the map component from the feature branch to master. A quick overview of the current state:

  • the web component is currently only planned to be a light-weight wrapper around OpenLayers
  • all essential files needed by a component package should have been added
  • missing some polish like tests and better API docs that we hope to get in before the end of the project
  • feature flag has been added
  • license check is not implemented yet

Type of change

  • Feature

packages/map/package.json Outdated Show resolved Hide resolved
packages/map/src/vaadin-map.js Outdated Show resolved Hide resolved
packages/map/src/vaadin-map.js Outdated Show resolved Hide resolved
packages/map/src/vaadin-map.js Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan changed the title feat: add map component feat: add map component behind a feature flag Jan 25, 2022
@sissbruecker sissbruecker merged commit dc6d693 into master Jan 25, 2022
@sissbruecker sissbruecker deleted the feat/map branch January 25, 2022 12:37
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha4 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants