Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: re-implement date-picker keyboard navigation #3372

Merged
merged 13 commits into from
Feb 4, 2022

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Feb 1, 2022

Description

Re-implemented the date-picker keyboard navigation based on the prototype by @vursen (see #3248).

Closes #3248

Type of change

  • Refactor

@web-padawan web-padawan force-pushed the feat/date-picker-a11y branch 2 times, most recently from eb88dd3 to cd03fed Compare February 2, 2022 07:59
Base automatically changed from test/date-picker-sendkeys to master February 2, 2022 09:10
@web-padawan web-padawan changed the base branch from master to refactor/date-picker-keydown February 2, 2022 09:44
@web-padawan web-padawan force-pushed the feat/date-picker-a11y branch 3 times, most recently from 2feb44e to e563074 Compare February 2, 2022 09:55
Base automatically changed from refactor/date-picker-keydown to master February 2, 2022 10:00
@web-padawan web-padawan changed the title [WIP] DO NOT MERGE: re-implement date-picker keyboard navigation refactor!: re-implement date-picker keyboard navigation Feb 3, 2022
@web-padawan web-padawan marked this pull request as ready for review February 3, 2022 10:17
@web-padawan web-padawan added the a11y Accessibility issue label Feb 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@tomivirkki tomivirkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great refactor 👍

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 23.0.0.beta2 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[date-picker] Improve the accessibility of the month calendar
4 participants