fix: update selected item styles to not limit height #3548
Conversation
web-padawan
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -23,7 +24,7 @@ registerStyles( | |||
|
|
|||
| /* placeholder styles */ | |||
| ::slotted(:not([slot]):not([selected])) { | |||
| line-height: normal; | |||
| line-height: 1; | |||
There was a problem hiding this comment.
For some reason, using normal on Windows causes the input container height to increase by 1 pixel.
This change caused the placeholder screenshot to be updated for Lumo.
There was a problem hiding this comment.
Are font descenders still visible with this change, for example, j and g?
There was a problem hiding this comment.
Can confirm that this works, single-line and multiline.
| @@ -54,8 +55,8 @@ registerStyles( | |||
| 'vaadin-select-value-button', | |||
| css` | |||
| :host { | |||
| min-height: var(--lumo-size-m); | |||
There was a problem hiding this comment.
This rule seems to be overridden by the vaadin-input-container styles.
| min-height: var(--lumo-button-size); | ||
| padding-top: var(--_lumo-selected-item-padding); | ||
| padding-bottom: var(--_lumo-selected-item-padding); |
There was a problem hiding this comment.
Aligned with the styles used by Vaadin 21:
* fix: reset height to make custom items fit * fix: set correct slotted item height
|
This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version. |
Description
Added styles to remove fixed height inherited from
vaadin-buttonto display custom item properly.Note, this only works in Lumo: multi-line items are not working using the Material theme for V14.
Fixes #3546
Type of change