chore: bump sinon to 13.0.2, fix sinon fake timers warnings #3699

vursen · 2022-04-19T07:44:17Z

Description

Bumped sinon to 13.0.2
Fixed sinon fake timers warnings: FakeTimers: clearTimeout was invoked to clear a native timer instead of one created by this library

That should fix the upload tests' failures:

packages/upload/test/upload.test.js:

 🚧 Browser logs:
      Error: Cannot clear timer: timer created with requestAnimationFrame() but cleared with clearTimeout()
        at clearTimer (node_modules/sinon/pkg/sinon-esm.js:4809:32)
        at packages/upload/src/vaadin-upload.js:606:19
        at progress (packages/upload/test/common.js:89:30)

 ❌ upload > Abort Files > should fire `file-remove` and remove from files
      Error: Error: Cannot clear timer: timer created with requestAnimationFrame() but cleared with clearTimeout() (http://localhost:8000/node_modules/sinon/pkg/sinon-esm.js:4815)
        at node_modules/@web/test-runner-mocha/dist/autorun.js:1:326426

Part of #3538

Type of change

Internal

Checklist

I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.