test: make keyboard tests more reliable #3793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
test/make-date-picker-tests-more-reliable
branch
from
ad43666
to
83e3e60
Compare
vursen
commented
May 6, 2022
| @@ -132,7 +132,8 @@ import { getDefaultI18n, getFocusedCell, getOverlayContent, open, waitForScrollT | |||
| const initialDate = new Date(2000, 0, 1); | |||
| overlay.initialPosition = initialDate; | |||
| await nextRender(overlay); | |||
| await overlay.focusDate(initialDate); | |||
| overlay.focusDate(initialDate); | |||
There was a problem hiding this comment.
note: overlay.focusDate() doesn't wait for the scroll animation to finish.
vursen
force-pushed
the
test/make-date-picker-tests-more-reliable
branch
from
83e3e60
to
4697171
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
May 6, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
May 6, 2022
web-padawan
pushed a commit
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added more
waitForScrollToFinishto ensure the date-picker has finished scrolling before checking that the correct cell is focused.A follow-up to #3659
Part of #3538
Type of change
Checklist