fix: observe parent resize to detect overflow #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
May 11, 2022
| disconnectedCallback() { | ||
| super.disconnectedCallback(); | ||
|
|
||
| this.__parentResizeObserver.unobserve(this.__parent); |
There was a problem hiding this comment.
I'm not sure what would be a proper way to test this, maybe will have to use a long timeout 🤷♂️
vursen
reviewed
May 11, 2022
tomivirkki
reviewed
May 11, 2022
tomivirkki
approved these changes
May 11, 2022
web-padawan
force-pushed
the
fix/menu-bar-parent-resize
branch
from
1ba3e56
to
34f44dd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
May 12, 2022
web-padawan
added a commit
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
ResizeObserverfor the menu-bar parent to detect cases when its width increases.Note, this does not cover the following case described in the original issue:
Fixes #3739
Type of change