fix: do not throw error when opened is set before adding to DOM #7335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tomivirkki
approved these changes
Apr 15, 2024
tomivirkki
reviewed
Apr 15, 2024
web-padawan
changed the title
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha24 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#6148
See also #4610 for a similar
vaadin-tooltipfix.When
openedis set to the select in the template as an attribute, in the Polymer version overlay opens before theready()callback is called. Theopenedis then reset tofalseas_overlayElementis empty, but due to the animation the overlay doesn't close immediately and is still under<body>by the timequerySelector()is called, so the error is thrown.Lit version doesn't have this issue since by the time
ready()is called on thevaadin-select, its overlay is not yet moved to the<body>. This is apparently because in Polymer, the order ofready()callbacks invocations is from child to parent (overlay -> select), and in Lit it's from parent to child (select -> overlay).Type of change