-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes odd double background color for typical code markup #7369
Conversation
Code snippets in Vaadin apps look weird without this fix.
I don't see any dot, what the heck is that complaint 🤷♂️ |
Removing spaces because it is important 🤷♂️
Quality Gate passedIssues Measures |
Apparently
means space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we can consider this as behavior altering fix.
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Code snippets in Vaadin apps look weird without this fix. @jouni says this fixes them all 💪
Example:
That kind of html is generated by e.g. all markdown generators
Type of change
Checklist