feat: fire closed event when Dialog overlay is closed #7471
Conversation
| describe('closed event', () => { | ||
| it('should dispatch closed event when closed', async () => { | ||
| const closedSpy = sinon.spy(); | ||
| listenOnce(dialog, 'closed', closedSpy); |
There was a problem hiding this comment.
Could use addEventListener instead of listenOnce. When using listenOnce, expect(closedSpy.calledOnce).to.be.true; wouldn't fail even if the event was dispatched twice
There was a problem hiding this comment.
There's no need to remove the event listener at the end of the test. Each test run gets a fresh new dialog instance.
Typing test added. |
| @@ -102,6 +109,7 @@ export type DialogEventMap = DialogCustomEventMap & HTMLElementEventMap; | |||
| * | |||
| * @fires {CustomEvent} resize - Fired when the dialog resize is finished. | |||
| * @fires {CustomEvent} opened-changed - Fired when the `opened` property changes. | |||
| * @fires {CustomEvent} closed - Fired when the overlay is closed. | |||
There was a problem hiding this comment.
This line is still different compared to .js file: it says "overlay is closed" vs "dialog is closed".
|
|
This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version. |
Description
Add a new
closedevent that is triggered after the overlay is closedPart of #7422
Type of change