Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not apply checkbox readonly background when disabled #7733

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Aug 30, 2024

Description

This was reported internall by @MatthewVaadin:

I was just working with checkbox states and noticed that if you set a checkbox to be checked (or indeterminate), disabled and readonly, you get a contrast that makes the check almost disappear

UPD: as discussed internally, let's make disabled state override the readonly to avoid contrast issue:

When it's disabled, the read only state is pretty much irrelevant.

Type of change

  • Bugfix

@web-padawan web-padawan changed the title fix: improve checkbox contrast when both readonly and disabled fix: do not apply checkbox readonly background when disabled Sep 2, 2024
Copy link

sonarcloud bot commented Sep 2, 2024

@web-padawan web-padawan removed the request for review from rolfsmeds September 2, 2024 07:46
@web-padawan web-padawan merged commit b00d1b6 into main Sep 2, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/checkbox-disabled-readonly branch September 2, 2024 07:47
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick b00d1b6
error: could not apply b00d1b6... fix: do not apply checkbox readonly background when disabled (#7733)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants