refactor: repurpose dashboard-gap as dashboard-spacing #7897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugur-vaadin
reviewed
Oct 1, 2024
| return [parseFloat(width)]; | ||
| })(); | ||
|
|
||
| // TODO: Fix the default minimum column width |
There was a problem hiding this comment.
Is this something to be addressed later?
There was a problem hiding this comment.
Addressed now with the current known default
ugur-vaadin
reviewed
Oct 1, 2024
packages/dashboard/test/helpers.ts
Outdated
| @@ -111,10 +111,10 @@ export function setRowspan(element: HTMLElement, rowspan?: number): void { | |||
| } | |||
|
|
|||
| /** | |||
| * Sets the gap between the cells of the dashboard. | |||
| * Sets the specing between the cells of the dashboard. | |||
There was a problem hiding this comment.
Nit: typo
Suggested change
| * Sets the specing between the cells of the dashboard. | |
| * Sets the spacing between the cells of the dashboard. |
|
ugur-vaadin
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames
--vaadin-dashboard-gapto--vaadin-dashboard-spacingand repurposes it to also affect the dashboard's padding.Part of https://github.com/orgs/vaadin/projects/70/views/1?pane=issue&itemId=75293217
Type of change
Refactor