Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python versions: add 3.6, remove EOL #78

Closed
wants to merge 15 commits into from
Closed

Update Python versions: add 3.6, remove EOL #78

wants to merge 15 commits into from

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 29, 2017

Fixes #56.

Python 3.2 is causing build problems (#56) and it's been decided it's easiest to drop it as it's EOL and no longer receiving security updates.

Now is also a good time to add Python 3.6 and remove the other EOL versions (2.5, 2.6, 3.2 and 3.3), which allows the code to be modernised.

Here's the pip installs for holidays from PyPI for the last month:

$ pypinfo --percent --pip holidays pyversion
python_version percent download_count
-------------- ------- --------------
2.7              70.7%         11,946
3.6              19.7%          3,332
3.5               7.3%          1,239
3.4               2.2%            376
2.6               0.0%              3
3.3               0.0%              1

Those versions are barely used if at all.

@hugovk
Copy link
Contributor Author

hugovk commented Oct 29, 2017

Note the build is failing due to #77 but here's a passing build with flake8 disabled:
https://travis-ci.org/hugovk/python-holidays/builds/294470197

I've confirmed locally no new flake8 issues are introduced.

This was referenced Oct 29, 2017
@coveralls
Copy link

coveralls commented Oct 29, 2017

Coverage Status

Coverage remained the same at 98.982% when pulling a05ea4a on hugovk:update-versions into 988bdf8 on ryanss:master.

@hugovk
Copy link
Contributor Author

hugovk commented Oct 29, 2017

I've tacked #80 onto this and now the build passes.

@dr-prodigy
Copy link
Collaborator

Superseded by 1452cc3 : please refresh your repo and re-apply small fixes not related to python version. Thx!

@dr-prodigy dr-prodigy closed this Jan 14, 2018
@hugovk
Copy link
Contributor Author

hugovk commented Jan 14, 2018

@dr-prodigy The main point of this PR is to remove those Python versions which are EOL (2.5, 2.6, 3.2 and 3.3), and then update the code to ease the maintenance burden and make use of more modern Python.

Here's updated pip installs for holidays from PyPI for the last month (via pypinfo --percent --pip --markdown holidays pyversion):

python_version percent download_count
2.7 76.0% 16,846
3.6 18.9% 4,194
3.5 3.6% 796
3.4 1.5% 332
2.6 0.0% 2
3.7 0.0% 1

Of the EOL versions, this shows only two installs for 2.6, and nothing for 2.5, 3.2 and 3.3.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 14, 2018

See PR #92!

@hugovk hugovk deleted the update-versions branch January 14, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants