-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python versions: add 3.6, remove EOL #78
Conversation
Note the build is failing due to #77 but here's a passing build with flake8 disabled: I've confirmed locally no new flake8 issues are introduced. |
I've tacked #80 onto this and now the build passes. |
Superseded by 1452cc3 : please refresh your repo and re-apply small fixes not related to python version. Thx! |
@dr-prodigy The main point of this PR is to remove those Python versions which are EOL (2.5, 2.6, 3.2 and 3.3), and then update the code to ease the maintenance burden and make use of more modern Python. Here's updated pip installs for holidays from PyPI for the last month (via
Of the EOL versions, this shows only two installs for 2.6, and nothing for 2.5, 3.2 and 3.3. |
See PR #92! |
Fixes #56.
Python 3.2 is causing build problems (#56) and it's been decided it's easiest to drop it as it's EOL and no longer receiving security updates.
Now is also a good time to add Python 3.6 and remove the other EOL versions (2.5, 2.6, 3.2 and 3.3), which allows the code to be modernised.
Here's the pip installs for holidays from PyPI for the last month:
Those versions are barely used if at all.