Use uint128 in everything possible

[3esmit]

Fixes #19

Description

Maybe is not the ideal, as it is increasing gas cost for everything due casting from uint256 => uint128, which carry checks on solidity. Maybe if we use unchecked{}?
But then whats the purpose of this?

Checklist

Ensure you completed all of the steps below before submitting your pull request:

• Added natspec comments?
• Ran forge snapshot?
• Ran pnpm lint?
• Ran forge test?

[0x-r4bbit]

So given that we're aiming for making this as inexpensive as possible, I wonder if we should really add these changes.

What are we gaining here, besides using less storage?

At the moment it really looks like this is just being more expensive?

[3esmit]

We are not using less storage, nor more. This changes add verifications on solidity. If we put a number bigger than an uint128 it will throw when casting.

[0x-r4bbit]

We are not using less storage,

I can run the storage layout tool over it, but given that we've changed a lot of storage variables from uint256 to uint128, two values now fits into a single slot, where as otherwise every variable would occupy an entire slot.

Am I missing anything?

[3esmit]

The storage was already uint128. What you mean is memory?

[0x-r4bbit]

These two are storage slots:

https://github.com/vacp2p/minime/pull/22/files#diff-89a231d7cc8434098e72bc9cd102408632360d03352b29a2c53d49b9fa34659aL71-R74

But you're right, it's just these two, everything else is not

[0x-r4bbit]

I'm gonna let this be your call.
Not sure these changes are an actual improvement. But that's fine by me.