enhancement/read-only-on-get #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandrigin
approved these changes
May 27, 2019
mandrigin
reviewed
May 27, 2019
state.go
Outdated
| s.RLock() | ||
| defer s.RUnlock() | ||
|
|
||
| if _, ok := s.state[group][id][sender]; !ok { |
There was a problem hiding this comment.
well, then you theoreticaly can even do
state, _ := s.state[group][id][sender]
return state
There was a problem hiding this comment.
Would state not be nil @mandrigin?
There was a problem hiding this comment.
it it is not a pointer, it shoudn't be it will be a default value of the struct
There was a problem hiding this comment.
|
@mandrigin running this code seems to run into a deadlock at one point, need to investigate further. |
|
It’s unlikely there, this code is pretty straightforward, but if you call Get or Set inside Map, that might bring trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.