work around send that may raise #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`send` can raise exceptions that together with asyncCheck will crash NBC
| # to escape to the poll loop. | ||
| # With a bit of luck, it may be harmless to ignore exceptions here - | ||
| # some cleanup is eventually done in PubSubPeer.send | ||
| traceAsyncErrors p.sendSubs(pubsubPeer, toSeq(p.topics.keys), true) |
There was a problem hiding this comment.
is this deliberate so we actually crash and catch the issue?
Also not sure how much that helps given our traces are hardly containing any relevant info.
This was referenced Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendcan raise exceptions that together with asyncCheck willcrash NBC