This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
feat(63/STATUS-Keycard-Usage): port from status specs #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
commented
Sep 8, 2023
Comment on lines
+134
to
+144
| "whisper-address": 20_byte_whisper_compatible_address, | ||
| "whisper-private-key": whisper_private_key, | ||
| "wallet-root-public-key": 256_bit_wallet_root_public_key, | ||
| "encryption-public-key": 256_bit_encryption_public_key,, | ||
| "wallet-root-address": 20_byte_wallet_root_address, | ||
| "whisper-public-key": 256_bit_whisper_public_key, | ||
| "address": 20_byte_address, | ||
| "wallet-address": 20_byte_wallet_address,, | ||
| "key-uid": 64_byte_unique_key_id, | ||
| "wallet-public-key": 256_bit_wallet_public_key, | ||
| "public-key": 256_bit_public_key, |
There was a problem hiding this comment.
@kaiserd who may i contact to ascertain the use of these parameters?
unsure about them, I would like to include them in the terminology up top for everyone to understand.
|
cc: @guylouis from the keycard team for a sanity check :) |
|
cc: @bitgamma too :) |
|
reviewed with @bitgamma
|
0x-r4bbit
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports 16/Keycard-usage to vac rfcs