Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wasm tests and ci #165

Merged
merged 3 commits into from
May 18, 2023
Merged

fix: wasm tests and ci #165

merged 3 commits into from
May 18, 2023

Conversation

rahulghangas
Copy link
Contributor

Unwrap result values in rln-wasm tests due to changed function signature
Fix CI, particularly rl-wasm tests were not being run

  • local testing

tyshko-rostyslav
tyshko-rostyslav approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@tyshko-rostyslav tyshko-rostyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rymnc
rymnc approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@rahulghangas rahulghangas merged commit d68dc1a into master May 18, 2023
@rahulghangas rahulghangas deleted the fix/wasm-tests-and-ci branch May 18, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyshko-rostyslav tyshko-rostyslav tyshko-rostyslav approved these changes

@rymnc rymnc rymnc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Vac Research
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulghangas @rymnc @tyshko-rostyslav