Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makefile): include wasm-pack+node in installation #240

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Apr 30, 2024

make installdeps does not include wasm-pack which prevents installation of dependencies

thanks @seemenkina for the report!

@rymnc rymnc requested a review from seemenkina April 30, 2024 09:11
@rymnc rymnc self-assigned this Apr 30, 2024
@rymnc rymnc added the bug Something isn't working label Apr 30, 2024
Copy link

Benchmark for 21c70ca

Click to view benchmark
Test Base PR %
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 354.9±3.30ns 320.6±10.03ns -9.66%
Pmtree::override_range 240.0±6.45µs 236.3±3.66µs -1.54%
Pmtree::set 56.0±0.70µs 55.9±1.61µs -0.18%
Pmtree:delete 55.9±0.34µs 55.9±0.40µs 0.00%

Copy link

Benchmark for 21c70ca

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 884.6±11.81ns 888.1±18.25ns +0.40%
FullMerkleTree::get 3.5±0.08ns 3.5±0.05ns 0.00%
FullMerkleTree::override_range 2.2±0.03µs 2.2±0.03µs 0.00%
FullMerkleTree::set 891.9±13.88ns 888.7±11.35ns -0.36%
OptimalMerkleTree::compute_root 1038.7±13.92ns 1042.7±16.06ns +0.39%
OptimalMerkleTree::delete 1032.5±13.70ns 1036.7±9.54ns +0.41%
OptimalMerkleTree::get 23.4±0.33ns 23.5±0.33ns +0.43%
OptimalMerkleTree::override_range 5.2±0.07µs 5.3±0.17µs +1.92%
OptimalMerkleTree::set 1032.0±7.21ns 1040.0±41.35ns +0.78%

@rymnc rymnc changed the title fix(makefile): include wasm-pack in installation fix(makefile): include wasm-pack+node in installation Apr 30, 2024
Copy link

Benchmark for 9c352dc

Click to view benchmark
Test Base PR %
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 318.7±6.12ns 320.0±6.84ns +0.41%
Pmtree::override_range 232.4±2.91µs 233.2±3.83µs +0.34%
Pmtree::set 56.3±2.45µs 55.8±0.48µs -0.89%
Pmtree:delete 55.9±0.59µs 55.9±1.24µs 0.00%

Copy link

Benchmark for 9c352dc

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 887.2±14.16ns 896.0±11.90ns +0.99%
FullMerkleTree::get 3.4±0.07ns 3.5±0.06ns +2.94%
FullMerkleTree::override_range 2.2±0.03µs 2.2±0.03µs 0.00%
FullMerkleTree::set 883.8±12.89ns 899.5±12.20ns +1.78%
OptimalMerkleTree::compute_root 1040.6±30.35ns 1039.0±8.60ns -0.15%
OptimalMerkleTree::delete 1030.4±8.11ns 1035.0±20.42ns +0.45%
OptimalMerkleTree::get 23.6±0.34ns 23.5±0.50ns -0.42%
OptimalMerkleTree::override_range 5.2±0.08µs 5.3±0.14µs +1.92%
OptimalMerkleTree::set 1029.7±22.31ns 1031.8±8.63ns +0.20%

Copy link

Benchmark for 4a4bd89

Click to view benchmark
Test Base PR %
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 328.2±5.44ns 322.4±5.25ns -1.77%
Pmtree::override_range 245.8±4.02µs 239.0±3.43µs -2.77%
Pmtree::set 55.8±0.54µs 56.8±2.07µs +1.79%
Pmtree:delete 56.0±0.75µs 55.9±0.61µs -0.18%

Copy link

Benchmark for 4a4bd89

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 886.2±14.82ns 883.5±14.35ns -0.30%
FullMerkleTree::get 3.5±0.06ns 3.5±0.07ns 0.00%
FullMerkleTree::override_range 2.2±0.01µs 2.2±0.05µs 0.00%
FullMerkleTree::set 887.6±12.30ns 889.3±15.09ns +0.19%
OptimalMerkleTree::compute_root 1039.8±14.92ns 1040.3±20.47ns +0.05%
OptimalMerkleTree::delete 1048.7±6.42ns 1032.1±9.30ns -1.58%
OptimalMerkleTree::get 23.4±0.33ns 23.4±0.31ns 0.00%
OptimalMerkleTree::override_range 5.2±0.10µs 5.3±0.13µs +1.92%
OptimalMerkleTree::set 1052.2±34.14ns 1034.4±20.41ns -1.69%

@rymnc rymnc merged commit d96eb59 into master Apr 30, 2024
10 checks passed
@rymnc rymnc deleted the fix-include-wasm-pack branch April 30, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants