Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose stdin and stdout #31

Closed
vadimdemedes opened this issue Aug 9, 2017 · 1 comment
Closed

Expose stdin and stdout #31

vadimdemedes opened this issue Aug 9, 2017 · 1 comment

Comments

@vadimdemedes
Copy link
Owner

Since stdin and stdout are customizable, all components should have access to them via context to avoid confusion. This is also useful for testing and stubbing those streams.

Before:

componentDidMount() {
  process.stdin.on('keypress', ...);
}

After:

componentDidMount() {
  this.context.stdin.on('keypress', ...);
}

Maybe those should just be set directly on this, not this.context, haven't decided about this yet.

@vadimdemedes vadimdemedes changed the title Expose stdin and stdout in context Expose stdin and stdout Aug 9, 2017
@vadimdemedes
Copy link
Owner Author

Fixed in Ink 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant