Allow passing an error on exit

[mAAdhaTTah]

Passing a result to exit will cause waitUntilExit to reject
with the value as the error.

Fixes #163.

[sindresorhus]

Why do you need to pass the error to exit() to have waitUntilExit() reject? I would have expected throwing an error anywhere in the Ink app would make waitUntilExit() reject.

[sindresorhus]

You need to update https://github.com/vadimdemedes/ink/blob/master/index.d.ts

[mAAdhaTTah]

Why do you need to pass the error to exit() to have waitUntilExit() reject? I would have expected throwing an error anywhere in the Ink app would make waitUntilExit() reject.

That seems like a larger issue to solve than this. I'm not sure how to add the plumbing to handle that unless React does a bunch of that work for us.

[vadimdemedes]

Why do you need to pass the error to exit() to have waitUntilExit() reject? I would have expected throwing an error anywhere in the Ink app would make waitUntilExit() reject.

That's actually a good idea. We already have an <App> component which wraps the whole Ink app. We could add componentDidCatch() there, which would reject waitUntilExit(). Feel free to leave it out of this PR, we can tackle it separately.

[mAAdhaTTah]

We already have an <App> component which wraps the whole Ink app. We could add componentDidCatch() there, which would reject waitUntilExit().

I dig it. I'd be willing to address that in a separate PR.

[mAAdhaTTah]

Updated.

[sindresorhus]

@mAAdhaTTah => https://github.com/vadimdemedes/ink/pull/165/files#r267193683

[mAAdhaTTah]

@sindresorhus I made that change. The #unmount on the App needs to take the error, but I updated the returned instance from render so it doesn't get passed along.

[mAAdhaTTah]

Minor adjustment made: I updated the test case to use the error object for console.log, so we verify that the error object is actually passed through the rejected promise.

[vadimdemedes]

Thanks @mAAdhaTTah, great work!

[vadimdemedes]

Could you fix the merge conflict, so that we can get it to master? ;)

[mAAdhaTTah]

Resolved.

[vadimdemedes]

Thanks @mAAdhaTTah, I will take another look tomorrow and merge it!

[mAAdhaTTah]

@vadimdemedes Not to be a pain, but a release with this fix + #170 would be really helpful for the CLI I'm working on. Thanks!

[vadimdemedes]

@mAAdhaTTah Sorry for the delay, I pushed some big changes in the core and wanted to give people a few a days to test them out. Going to release in a few minutes ;)

[vadimdemedes]

New release is out - https://github.com/vadimdemedes/ink/releases/tag/v2.1.0 🎆

[mAAdhaTTah]

No worries, thank you!