Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a __dataframe__ method to _VaexDataFrame #2205

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

rgommers
Copy link
Contributor

This will align the implementation with those in other libraries, xref data-apis/dataframe-api#80.

Cc @maartenbreddels, @honno

@rgommers
Copy link
Contributor Author

(apologies for iterating in CI, I was a bit too lazy to set up a dev environment for these few lines of code)

@rgommers
Copy link
Contributor Author

This seems happy now, the 4 CI failures I inspected are all HTTPClientError: HTTP 502: Bad Gateway.

@honno
Copy link
Contributor

honno commented Sep 13, 2022

FWIW dataframe_protocol_tests.py and the relevant dunder-df tests in dataframe-interchange-tests pass for this PR locally.

(If the bad gateway stuff gets resolved, note there's other issues with interchange stuff on win/mac CI #2150 (comment))

@rgommers
Copy link
Contributor Author

@maartenbreddels I somehow keep getting notifications for new failures on reruns of CI jobs. No worries if you are doing that on purpose - if not, something is probably off in the GitHub Actions config in this repo.

The only failures are still (7x):

FAILED tests/viz_test.py::test_heatmap_with_what[webserver_fastapi-ds_filtered-tornado_client]

This will align the implementation with those in other libraries,
xref data-apis/dataframe-api#80
@maartenbreddels
Copy link
Member

Yeah, that was me :) I had to rebase, hopefully it is green now.

@maartenbreddels
Copy link
Member

green enough, thanks Ralf!

@maartenbreddels maartenbreddels merged commit 3694e06 into vaexio:master Sep 23, 2022
@rgommers rgommers deleted the add-dunder-dataframe branch September 23, 2022 12:02
@rgommers
Copy link
Contributor Author

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants