Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit-test for the unique method when the column created from bytes #325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Unit-test for the unique method when the column created from bytes #325

wants to merge 2 commits into from

Conversation

JovanVeljanoski
Copy link
Member

Adding a unit-test which tests the unique method, in the case when the column is created from bytes. At the moment this exposes a potential issue.

@maartenbreddels
Copy link
Member

I'm not super happy with this fix, since it basically converts bytes to strings.

@JovanVeljanoski JovanVeljanoski mentioned this pull request May 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartenbreddels maartenbreddels Awaiting requested review from maartenbreddels

Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JovanVeljanoski @maartenbreddels