Update operations do not update the td id correctly #18
Conversation
relu91
changed the title
|
I would say it is better to be verbose than vague.
|
|
Ok then I think we have a consensus here: I've also noticed that we have |
| private async checkDuplicateThingDescriptionId(urn: string, id: string | undefined): Promise<void> { | ||
| if (!id || id === urn) return; | ||
| const idExist = await this.thingDescriptionRepository.exist({ where: { urn: id } }); | ||
| if (idExist) throw new DuplicateIdException(id as string); | ||
| } |
There was a problem hiding this comment.
The function signature could become clearer by renaming the parameters urn and id to something like currentId and newId.
There was a problem hiding this comment.
The code is great. Thanks for the work!
If possible, it would be important to add a couple of failing tests (for both the PUT and PATCH) when the client tries to change the TD id to an existing one. Basically check the correct behavior of the checkDuplicateThingDescriptionId in the respective two cases.
…ThingDescriptionId
…already existing id
Done in commit #2dc14bb . |
|
To maintain consistency, I will open another branch to do it. That way, we have a 1-to-1 relationship between issues, branches, and PRs. |
|
Ok, I thought that in 55f7688 you updated also the other methods. Then it's ok as it is! |
When a TD is updated (PUT or PATCH), the
internalThingDescriptionurn is updated as well. Additionally, there is an additional check to ensure that the new id is not a duplicated one. The new exception is:{ "type": "/errors/types/duplicate-id", "title": "Duplicate Id", "status": 409, "detail": "The id {id} is already in use by another Thing Description" }