-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @context URLs, add response contentType workaround #52
Conversation
f318c6a
to
8f0b128
Compare
Needed to update two dependencies and create another workaround in 8f0b128 to get the TD instantiation to actually work again. Seems to me like a bug has appeared in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jan! As always thank you really much for contributing to Zion. The changes look good, but I checked the difference in package-lock and saw changes in unrelated packages like Fastify. Do you have an idea why this is happening? Can you try to narrow down the changes to only node-wot and wot-thing-description-types packages?
Hi Cristiano, thank you for the feedback! Sure, I will check again and try to narrow down the changes :) |
With the latest push, I managed to trim down the changes in the |
Ok, in my understanding we are going to release 0.8.6 very soon. I'll check if we get the green light once it will be published! |
The new |
I am now wondering: Should we wait for w3c/wot-discovery#471? Or would it be fine to already merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ok for merging this right now, I'm confident that the linked PR in the discovery repo will be merged soon.
w3c/wot-discovery#471 has now been merged by the way, so the spec is not a potential blocker anymore :) |
Talked offline with @hyperloris, he was a little bit uncomfortable with merging a PR with TODOs in it. I agree but those TODOs are reasonable and they can be tracked in issues (as suggested by @hyperloris himself). Therefore, I'm forcing the merging of the PR without waiting for his formal approval. Later on, I'll open the tracking issues. |
This PR updates the @context URLs included in the directory's TM/TD in anticipation of w3c/wot-discovery#471 and applies the workaround added in w3c/wot-discovery#469 to the
ThingDescriptionBuilderService
by insertingapplication/x-empty
as acontentType
forresponse
objects where the field absent.Combined, these changes result in a TD for the Directory that passes validation against the latest JSON Schema document provided in the TD repository :)