Update npm packages #326
Update npm packages #326
Conversation
There was a problem hiding this comment.
Browser review
- A new major storybook version is available.
- There is an error about a storybook add-on when running storybook:
- There are two errors about static vs. dynamic imports when building. I think the one about
apican be resolved by always do a static import. I think the other one can not be resolved.
I could not fix this without introducing another problem either in storybook or in the tests. I will for now leave it as it is. But we should investigate this a bit more, because to me it looks like we have a setup issue here. |
|
@mob8607 this PR is still open. Do you have the possibility to check your questions with someone else? Not sure, when I will be ready to check your questions with you... |
|
@patric-eberle @benjamin-joham |
# Conflicts: # .nvmrc
# Conflicts: # package-lock.json # package.json
Feature/msw update
@mob8607 can you please create a ticket about what needs to be checked? I currently can't remember the whole context of this while you might do ;) |
There was a problem hiding this comment.
Added inputs about some package versions. Please double check.
- There is an endless list of warnings when running
npm run test. I think this could be caused by the invalid vite version:[eslint-plugin-import:resolver:vite] Cannot use import statement outside a module -
npm run storybookshows the following warning. Can we resolve this?
| "vite": "~4.4.9", | ||
| "svgo": "~3.2.0", | ||
| "typescript": "~5.3.3", | ||
| "vite": "~4.4.12", |
There was a problem hiding this comment.
todo: according to the release information, @vitejs/plugin-vue in version 5 is no longer compatible with vite 4.x: https://github.com/vitejs/vite-plugin-vue/blob/main/packages/plugin-vue/CHANGELOG.md#500-2023-12-25
package.json
Outdated
| "sass": "~1.69.6", | ||
| "storybook": "~7.6.7", | ||
| "stylelint": "~16.1.0", | ||
| "stylelint-config-valantic": "github:valantic/stylelint-config-valantic#48b8f70490dc0b4bae69518d7f9efc2e762eda55", |
There was a problem hiding this comment.
todo: please make sure we create a release of sylelint-config-valantic before this is merged.
| @@ -119,12 +119,11 @@ | |||
| * For browser support @see https://caniuse.com/?search=load | |||
| */ | |||
| loading: { | |||
| type: String, | |||
| type: String as PropType<'lazy' | 'eager'>, | |||
…re/npm-updates Conflicts: package-lock.json package.json
|
@mob8607 can you please resolve the merge conflicts before I check this again. THX. |
…re/npm-updates Conflicts: package-lock.json package.json src/styleguide/components/s-api-mock-test.vue src/styleguide/mock-data/data-object/image.ts tests/unit/specs/plugins/vue-bem/testingEntitys.ts tsconfig.json
…re/npm-updates Conflicts: src/styleguide/api/handler.js
|
@patric-eberle It should now be up to date and ready |
Pull request
Updates outdated npm packages.
Currently not updated:
Browser testing
Checklist
Review/Test checklist